tellytv / telly

An IPTV proxy
MIT License
760 stars 104 forks source link

telly should sanitize URLs wherever they appear in logs #186

Open chazlarson opened 6 years ago

chazlarson commented 6 years ago

telly release with the issue:

1.1.0.2

Last working telly release (if known):

Operating environment (Docker/Windows/Linux/QNAP, etc.):

All

Description of problem: See https://github.com/tellytv/telly/issues/183

telly received a timeout when trying to retrieve a URL, and then spit the unredacted URL into the log when reporting the connection failure.

Contents of telly.config.toml [if you're using a version above 1.1]:


**Command line used to run telly [if applicable]:**
- REMEMBER TO DELETE ANY CREDENTIALS IN CONFIG FILES OR COMMAND LINES

**Docker run command used to run telly [if applicable]:**
- REMEMBER TO DELETE ANY CREDENTIALS IN CONFIG FILES OR COMMAND LINES

**telly or docker log:**


**Additional information:**
robbiet480 commented 6 years ago

I don't control that error message sadly, Go does. We could filter it out of error messages though by scanning every error string but not high priority atm.

cmcpherson274 commented 6 years ago

I think this might be related to #181 . The url might have been invalid b/c of the space.

chazlarson commented 6 years ago

Regardless of why the URL is invalid, I think it'd be nice to keep credentials out of the logs in all circumstances, but can see why that could be a hassle.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.