search

tellytv / telly

An IPTV proxy
MIT License
769 stars 106 forks source link

hdhr device ids are alpha numeric #245

Closed tmm1 closed 5 years ago

tmm1 commented 5 years ago

HDHomeRun device ids are not numeric. Since discover.json exposes the id as a string, it doesn't make sense to read it in as an int.

This is important for compatibility with Channels app, which needs to be able to receive customized device ids which contain letters.

I haven't tested this very well yet. Presumably more changes will be needed to ensure backwards compatibility with config files that still specify a number instead of a string.

tmm1 commented 5 years ago

I haven't tested this very well yet. Presumably more changes will be needed to ensure backwards compatibility with config files that still specify a number instead of a string.

Looks like spf13/viper uses spf13/cast which handles conversion to strings automatically, so this is working as expected with both numeric and string ids in the toml configuration file.

tmm1 commented 5 years ago

Looks like I broke the tests in this PR. Is there a reason circleci isn't running?