search

tellytv / telly

An IPTV proxy
MIT License
750 stars 105 forks source link

Remove -re from ffmpeg command #267

Closed iMiMx closed 4 years ago

iMiMx commented 4 years ago

Remove '-re' from ffmpeg command, was causing buffering/packet loss. From the ffmpeg docs:

-re (input)

Read input at native frame rate. Mainly used to simulate a grab device, or live input stream (e.g. when reading from a file). Should not be used with actual grab devices or live input streams (where it can cause packet loss).

chazlarson commented 4 years ago

Seems to make sense. Can't find any discussion on why that's there. Have you tried it in the usual use case? Feeding Channels DVR with TVHeadend isn't a typical use case, so does it make sense to put this behind a config option?

iMiMx commented 4 years ago

Option to edit/override the FFmpeg commands would be the best option, I agree.

I would argue that any IPTV feed should be classed as a 'live input stream', however, TVHeadend or A.N.Other.

tmm1 commented 4 years ago

This option slows down the rate at which ffmpeg reads from the source device. I don't think it makes sense for any use of Telly. Was there a reason it was added originally?

chazlarson commented 4 years ago

I don't know what that reason was; it might be in the discord somewhere; I recall discussion about what the ffmpeg options should be and one dude offering the options that ended up in use.