Closed kurtnalty closed 4 years ago
Easy PR - when updated can be merged && we can create the first release of 2019
On Mon, 31 Dec 2018 10:32:34 -0800 Nico Schottelius notifications@github.com wrote:
telmich commented on this pull request.
@@ -173,7 +173,7 @@ static void gpm_suspend_hook (int signum) / Reincarnation. Prepare for another death early. / sigemptyset(&sa.sa_mask); sa.sa_handler = gpm_suspend_hook;
- sa.sa_flags = SA_NOMASK;
- sa.sa_flags = SA_NODEFER;
Question : NOMASK == NODEFER is defined where?
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/telmich/gpm/pull/30#pullrequestreview-188524971
reference:
http://man7.org/linux/man-pages/man2/sigaction.2.html
Relevant section
SA_NODEFER
Do not prevent the signal from being received from within
its own signal handler. This flag is meaningful only when
establishing a signal handler. SA_NOMASK is an obsolete,
nonstandard synonym for this flag.
On Mon, 31 Dec 2018 10:33:01 -0800 Nico Schottelius notifications@github.com wrote:
telmich commented on this pull request.
@@ -33,7 +33,7 @@
include <sys/types.h> / socket() /
include <sys/socket.h> / socket() /
include <sys/un.h> / struct sockaddr_un /
-#include <sys/fcntl.h> / O_RDONLY / +#include
/ O_RDONLY / include <sys/stat.h> / stat() /
Nit picking: Can you keep comment indent correct here?
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/telmich/gpm/pull/30#pullrequestreview-188525016
My apology, of course the indent should match!
Will fix on github.
Hi!
I added these corrections to my gpm fork. @telmich if you want you can merge it, which includes the other corrections for musl. I think it's now complete with the @kurtnalty fixes.
These changes enable compilation of gpm using gcc 4.6.4 and the musl C library 1.1.20. These changed don't break compilation with gcc/glibc.