Open posophe opened 9 years ago
posophe
commented
8 years ago The way you're talking about is not the standard one. Without the patch (actually applied on gpm sources in openSUSE), Make BUILDROOT=%{buildroot} isn't handled correctly by make.
vapier
commented
8 years ago it is standard: make install DESTDIR=/some/path works the same in gpm as automake based projects.
your changes, as written, break that behavior because DESTDIR gets expanded twice.
posophe
commented
8 years ago I didn't make the initial patch. Let me just talk to the original author about the changes, and the why they've been done this way.
vapier
commented
8 years ago all the commits have your name on them. if you aren't the author, then you should be fixing your git commits to correctly attribute the original author.
telmich
commented
8 years ago @vapier it's great to see you still being around and sanity checking - thanks a lot for your efforts!
kloczek
commented
12 months ago Any chance to merge this PR and release new version? 🤔
kloczek
commented
12 months ago Indeed in https://github.com/telmich/gpm/pull/6/commits/16628b44e999225c6bcf099bba004cb13be5324f is typo
which is possible to fix by s,$(DESTDIR) $(includedir)/gpm.h,$(DESTDIR)$(includedir)/gpm.h,
Nevertheless install should use DESTDIR style install as all autoconf or autoconf/automake using projects and this PR fixes that.
vapier
commented
12 months ago this PR is actively broken/bad as i described. look at how DESTDIR is expanded twice.
i'm not against deleting ROOT and moving DESTDIR to the individual rules rather than putting into the immediate path variables, but this PR doesn't do that.
if you want to submit a new PR that correctly fixes things, then please do. this PR, as-is, is not safe, and cannot be merged.
this doesn't seem to make sense. the build already supports DESTDIR -- see the Makefile.include.in and how it utilizes ROOT/DESTDIR.