teloscube / decaf-client-javascript-extras

https://teloscube.github.io/decaf-client-javascript-extras/
MIT License
0 stars 0 forks source link

add grouping option to holdings tree maker #38

Closed alioguzhan closed 3 weeks ago

alioguzhan commented 3 weeks ago

currently makeValuationReportHoldingsTree groups holdings by classification. It is default and fixed. We should make it configurable to group by classification or sector or industry or country or currency.

https://github.com/teloscube/decaf-client-javascript-extras/blob/f0247da9dde73c028e325df6fa427f79fb9580b2/src/reports/valuation/-valuation-report-holdings-tree/-machinery.ts#L172

alioguzhan commented 3 weeks ago

I am going to steal below section from headless folder and integrate it here:

image

@vst Do you have any objection for this ?

vst commented 3 weeks ago

No objection your Honor.

vst commented 3 weeks ago

Niye close ettiysem :)