telosnetwork / open-block-explorer

The Open Block Explorer (OBE) is the first open source block explorer that is designed to support all AntelopeIO-based blockchains.
https://explorer.telos.net
Apache License 2.0
27 stars 24 forks source link

send token filtering broken #651

Closed Viterbo closed 1 year ago

Viterbo commented 1 year ago

Fixes #623

Description

The SendDialog component was setting TLOS as the default token to send, displaying the available amount on top of the field. The bug shows when the account has a zero TLOS balance because of a broken pointer access.

The bug was fixed and the new default behavior is to select TLOS if its balance is positive. Otherwise, open the token selection dialog and force you to select one from the list.

Test scenarios

Checklist:

netlify[bot] commented 1 year ago

Deploy Preview for obe-staging ready!

Name Link
Latest commit cf5c9e24a805b0fbb974fc032b0f59e644c733e5
Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/640f85e79709e60008003cbc
Deploy Preview https://deploy-preview-651--obe-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for obe-testnet ready!

Name Link
Latest commit cf5c9e24a805b0fbb974fc032b0f59e644c733e5
Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/640f85e7d2b97b00081b534f
Deploy Preview https://deploy-preview-651--obe-testnet.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf5c9e2
Status: ✅  Deploy successful!
Preview URL: https://d402926a.open-block-explorer.pages.dev
Branch Preview URL: https://623-send-token-filtering-bro.open-block-explorer.pages.dev

View logs