search

telosnetwork / open-block-explorer

The Open Block Explorer (OBE) is the first open source block explorer that is designed to support all AntelopeIO-based blockchains.
https://explorer.telos.net
Apache License 2.0
27 stars 24 forks source link

Execute MSIG tx by non MSIG Accounts on Block Explorer #835

Closed pmjanus closed 6 months ago

pmjanus commented 8 months ago

On MSIG tx, allow any account to execute it, currently only MSIG accounts can it seems.

Refinement: The problem is that the condition isApproved is currently calculated wrong.

Let's call this first case a private proposal in which only private accounts are part of the requested approvals. In this case the isApprovedproperty should be taking into account the amount of requested versus approved and they have to be the same. http://localhost:8080/proposal/voqbcbtcll3j image

Let's call this other case a public proposal where the approval of BPs where solicited. In this other different case, we need at least (2/3+1) of the total amount of active BPs having approved the proposal. Only in that case, the proposal is approved. http://localhost:8080/proposal/aprfeeburn image

rozzaswap commented 7 months ago

May already be resolved by https://github.com/telosnetwork/open-block-explorer/pull/829

Viterbo commented 6 months ago

I'm reopening this issue because it seems not to work on production.

Viterbo commented 6 months ago

This issue is solved. You can see in this already-approved proposal that the execute buttons appear even when I'm logged in with an account that has not participated from the miiltisig. however, you need to be logged to see the button.

https://explorer-test.telos.net/proposal/axlspauos13o

image