telosnetwork / open-block-explorer

The Open Block Explorer (OBE) is the first open source block explorer that is designed to support all AntelopeIO-based blockchains.
https://explorer.telos.net
Apache License 2.0
27 stars 24 forks source link

Fix proposal execute button - fixing the math for isApproved #842

Closed Viterbo closed 6 months ago

Viterbo commented 7 months ago

Fixes #835, #841

Description

This PR repairs the login behind the condition of isApproved. it also fixes a problem with the .env when it's not present (fresh repo clone).

Test scenarios

or run it locally with this code:

# clone the repo if you don'e have it
git clone https://github.com/telosnetwork/open-block-explorer.git
cd open-block-explorer
# run the correct branch
git fetch origin
git checkout 835-execute-msig-tx-by-non-msig-accounts-on-block-explorer
yarn
yarn dev

make sure you have the file .env with this code:

APP_NAME=OBE
CHAIN_NAME=telos

then visit http://localhost:8080/proposal/aprfeeburn

image

Checklist:

netlify[bot] commented 7 months ago

Deploy Preview for obe-testnet ready!

Name Link
Latest commit f88529ddd6db1076cbe709bb874e8256bbc42440
Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/660f1e8dffe3380008f090f1
Deploy Preview https://deploy-preview-842--obe-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 7 months ago

Deploy Preview for obe-staging ready!

Name Link
Latest commit f88529ddd6db1076cbe709bb874e8256bbc42440
Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/660f1e8da6504e00086f98d0
Deploy Preview https://deploy-preview-842--obe-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.