Disable the checks for state trie root hash during execution

telosnetwork / telos-reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust

Apache License 2.0

2 stars 0 forks source link

Disable the checks for state trie root hash during execution #4

Closed aamirpashaa closed 3 weeks ago

aamirpashaa commented 9 months ago

Describe the feature

Since in Telos EVM, there is no state trie storage, it doesn't have any state trie root hash and in a block, it is set to the default blank value (0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421). So the check for validation of state trie root hash should be omitted.

Additional context

No response

poplexity commented 1 month ago

We may want to turn this back on, leaving issue open until that decision is made.

poplexity commented 3 weeks ago

We will not be turning this back on, as block hash needs to be generated/provided by consensus client and it does not have a valid state root to use for generating the hash, it introduces immense complexity and risk.