telosnetwork / telos-reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
Apache License 2.0
2 stars 0 forks source link

Investigate how to reduce feature flags #62

Open poplexity opened 1 week ago

poplexity commented 1 week ago

Ideally all changes are contained in crates within the crates/telos directory, and not managed via feature flags. This issue is to track investigation into how we could reduce feature flags by moving changes into the telos directory.

If we look at how optimism has added their customizations, we can see there is intentional ways to customize reth which we are not yet using.

Also, where we have implementations in the telos directory which do not involve telos specific changes, we'd like to avoid any code duplication so we do not miss future updates/fixes.

Examples... note that there are likely many more cases we can improve on, which should be added to this issue so we can track their resolution.

poplexity commented 1 week ago

Adding more... we currently don't plan to support starting from non-zero genesis and there might be a few places we can just remove our changes entirely, need to confirm with @aamirpashaa which places these would be. (example, storage/db-common crate)