telosnetwork / telos-reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
Apache License 2.0
2 stars 0 forks source link

Rebase 1.0.8 #64

Closed poplexity closed 1 month ago

poplexity commented 1 month ago

This work is done partially... the telos-reth-main-new-jesse branch has it rebased WITHOUT the changes from the store_gas_revision branch. The store_gas_revision_rebase branch has the storage changes on top of the 1.0.8 changes but it does not compile.

In either 1.0.7 or 1.0.8 upstream reth moved their definition of the Header table from reth to use the one provided by alloy_consensus. The latest commit 4d05c1d310ff695ae328c5adb0616652d716ebcf on store_gas_revision_rebase attempts to replace the alloy Header struct with our own, and it might be close. We need to avoid forking alloy, this would be one possible solution.

Alternatively, we need to store this data in a different table. We can do this in a subsequent version after we release 2.0, but it will change storage and require a resync, for this reason we need to investigate this ASAP before we consider releasing for partners to run the 2.0 version, so we don't ask them to resync on the very next release.