telosnetwork / telos-wallet

Native & EVM Web Wallet for transfers, staking, digital collectibles, and more
https://wallet.telos.net
Apache License 2.0
9 stars 8 forks source link

Add switch network prompt if not on telos #22

Closed donnyquixotic closed 11 months ago

donnyquixotic commented 2 years ago

add network confirmation/switch logic for metamask-related transactions image

karynemayer commented 1 year ago

@donnyquixotic @poplexity Could this be a future feature where we could make it easier to connect the metamask to change the chain and address? You would be prompted to add telos EVM network if you don't have it listed and copy the EVM address to the to EVM field.

@Viterbo @Kersten-TCD @EJSG

poplexity commented 1 year ago

For now I don't think we want metamask to pop up at all, not sure why it is?

Kersten-CR commented 1 year ago

I would propose to find the bug and remove it for now, still strange it would try to connect to MetaMask anyway. May be the MM screen remained active from a different or previous browser tab?

We will look at the integration to station once we focus on EVM connection.

Viterbo commented 1 year ago

I having some trouble to even understanding what is the bug/problem. From what I understand, the website does not interact at all with Metamask because is not needed for anything. All transactions are pushed to eosio.evm contract and therefore no Metamask interaction is needed.

I'm marking this issue as "blocked" and "needs grooming" because we don't have a clear definition of the problem and/or acceptance criteria.

Kersten-CR commented 1 year ago

@donnyquixotic I have never investigated this behavior, can you recreate this? If not, we may want to close this issue here.

karynemayer commented 1 year ago

@Kersten-TCD do you know where we interact with the metamask?

Kersten-CR commented 1 year ago

Not (yet) anywhere within the web-wallet, app.native or OBE, this is only supported for Teloscan and will be for Telos Station going forward.

donnyquixotic commented 11 months ago

Resolved