Read/write interface doesn’t handle arrays properly

poplexity commented 2 years ago

Overview

When interacting with the contract function interface, some/all array arguments will incorrectly produce an error.

Steps to reproduce

ensure you have a wallet connected
Go to https://www.teloscan.io/address/0xb9239af0697c8efb42cba3568424b06753c6da71#contract
Click on the Write tab
Scroll down to the method swapETHForExactTokens
enter values shown in the screenshot below (any address can be used)
note the error

Current behavior

Method call fails with the error Result (uint256[]): invalid value for array (argument="value", value="[0x160505F3dfD1cb58B91e322c828Ae0F74c043c3C]", code=INVALID_ARGUMENT, version=contracts/5.7.0)

Note: need to determine a set of valid values that should work, not just error in a different way

Expected behavior

method should fail for a different reason, this error suggests an issue with parsing array type arguments (possibly only address[] in this case). The fix for this should be tested to at least not break (or fix, if they're broken) the currently-implemented argument types, uint256 and uint256[] along with introducing a working address[] and address. Implementation of other parameter types as well as improved error UI will be handled in #104

additionally:

for each of the four types, helpful error messaging should be printed in below the form input as a stopgap until UI work in #104 is completed. This validation should occur on blur and after a paste from clipboard
a disclaimer should be added at the top of the ABI UI informing the user that certain data types are yet to be implemented, and will be added soon

poplexity commented 2 years ago

718703BD-A32A-4CBD-83CA-267FA475090E