search

telstrapurple / PurpleExplorer

cross-platform Azure Service Bus explorer (Windows, MacOS, Linux)
MIT License
163 stars 33 forks source link

Add Bulk Transfer DLQ functionality #44

Closed davec643 closed 2 years ago

davec643 commented 2 years ago

Fix bug where the app crashed if the ServiceBusConnection failed

davec643 commented 2 years ago

Upgrading to net6.0 to support ARM64 compilation Upgraded the Avolonia packages to the latest to resolve an issue with MacOS Retina screen scaling.

armannaj commented 2 years ago

Thanks for contributing .. Sounds like a big pull request

davec643 commented 2 years ago

Thanks for contributing .. Sounds like a big pull request

@armannaj I've updated the Github workflow pipelines as well and included compiling for osx-arm64, but for some reason the files aren't tracking... The updates are in my fork if you want to try migrate them.

armannaj commented 2 years ago

Thanks for contributing .. Sounds like a big pull request

@armannaj I've updated the Github workflow pipelines as well and included compiling for osx-arm64, but for some reason the files aren't tracking... The updates are in my fork if you want to try migrate them.

Approved it, Could you also look at the comments I posted above please?

davec643 commented 2 years ago

Approved it, Could you also look at the comments I posted above please?

Apologies @armannaj, this is my first time raising a PR on GitHub, where are the comments that you posted?

armannaj commented 2 years ago

Approved it, Could you also look at the comments I posted above please?

Apologies @armannaj, this is my first time raising a PR on GitHub, where are the comments that you posted?

@davec643 All good mate, I hadn't submit the comments. I just did. Also the build is failing, It's missing a package.

These are great changes and I'm keen to add them so that everyone can use it ASAP. Thanks.

davec643 commented 2 years ago

@armannaj Pushed up some changes for your comments.

As for the build, it's failing because it's trying to build using .NET Core 3.1, but the project is now .NET 6.0. I think you'll just need to merge it with the failing build before it'll compile properly -- see my forked repo for example.