Release receiver when going to null state

teltek / gst-plugin-ndi

GStreamer NDI Plugin for Linux

GNU Lesser General Public License v2.1

155 stars 27 forks source link

Release receiver when going to null state #59

Closed Townsheriff closed 2 years ago

Townsheriff commented 3 years ago

I was adding and removing ndi audio sources in playing state and encountered that same source cannot be attached twice and plugin failed with "Source with NDI name '{:?}' / URL/address '{:?}' already in use for {}" error.

When debugging I figured that drop was never called for ReceiverInner and the reason for that was state.receiver was never released.

sdroege commented 2 years ago

This should be irrelevant now with the refactoring of the source (CC @samuvlad )