telus / tds-community

TELUS Design System Community Components
https://tds.telus.com/community/index.html
MIT License
28 stars 7 forks source link

[ProgressBar] use styled <progress> instead of styled <div> #178

Open marcod1419 opened 5 years ago

marcod1419 commented 5 years ago

Description

The current ProgressBar does not get picked up at all by screen readers. Therefore, any information given by it is completely inaccessible to those using assistive technology.

This can most likely be improved by incorporating the HTML progress element. (See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress)

Another approach worth noting is one used for TELUS Wise, where an implementation similar to this used aria labels to communicate progress. (See screenshot section) However, I believe that using the progress element would provide maximum context for less effort.

Reproduction Steps

Meta

Screenshots

VoiceOver picking up the HTML progress element: image

Existing accessible TELUS progress bar: image

Aria attribute preview for existing TELUS accessible progress bar: image

invalidred commented 5 years ago

Do we know of a team that uses <Progress />? @bnadeem-telus is the a dev in you tribe that can look into this?