search

temando / serverless-openapi-documentation

Serverless 1.0 plugin to generate OpenAPI V3 documentation from serverless configuration
MIT License
93 stars 127 forks source link

Fix loading of request models and *params #28

Closed adambartholomew closed 6 years ago

adambartholomew commented 6 years ago

Combining the commits/comments from the two outstanding PRs. Credit to https://github.com/jhaagmans

https://github.com/temando/serverless-openapi-documentation/pull/27 https://github.com/temando/serverless-openapi-documentation/pull/24

I can also confirm that *params and the requestModel properties are being ignored in the serverless.yml configuration. The DefinitionGenerator needs to check for a value in the documentationConfig, not the being-generated operationObj.

This seems to be a regression from 0.3 > 0.4.

jhaagmans commented 6 years ago

@adambartholomew I don't see any differences between this PR and #27.

adambartholomew commented 6 years ago

You are correct. Apologies, I went back and forth with some ideas. Closing this PR.