search

tembo-io / pg_vectorize

The simplest way to build AI workloads on Postgres
https://tembo.io/pg_vectorize/
739 stars 33 forks source link

Remove outdated parameters from vectorize.table() #176

Closed zyronite closed 2 weeks ago

zyronite commented 3 weeks ago

What does this PR do?

This PR adds support for chunking text in input columns for the vectorize.table function, enhancing document subset retrieval.

/fixes #146 /claim #146

algora-pbc[bot] commented 3 weeks ago

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

zyronite commented 3 weeks ago

@jasonmp85 & @ChuckHend - Guys another one give this a merge too! Hope this'll fix the Issue as asked, If any changes needed further - Lemme know?!

Neptune650 commented 3 weeks ago

@zyronite Hey, I don't understand what exactly this PR does different... The linting fails though, I made my PR because the previous one wouldn't build, but how is this one different.

Neptune650 commented 3 weeks ago

Also it seems like you're just doing plagiarism, https://github.com/tembo-io/pg_vectorize/pull/175#issuecomment-2441407515 this one too is just an old commit of my PR.

ChuckHend commented 3 weeks ago

as far as I can tell, https://github.com/tembo-io/pg_vectorize/pull/158 was the first PR to address https://github.com/tembo-io/pg_vectorize/issues/146, so we will be working with that one first.

Neptune650 commented 3 weeks ago

as far as I can tell, https://github.com/tembo-io/pg_vectorize/pull/158 was the first PR to address https://github.com/tembo-io/pg_vectorize/issues/146, so we will be working with that one first.

@ChuckHend Correct, then I sent #171 because #158 wasn't building.

ChuckHend commented 2 weeks ago

Hey @zyronite , https://github.com/tembo-io/pg_vectorize/pull/158 merged earlier so we closed out this issue and the bounty. Let me know if you have additional scope, otherwise I think we can close this PR.

Neptune650 commented 2 weeks ago

Hey @Neptune650 , https://github.com/tembo-io/pg_vectorize/pull/158 merged earlier so we closed out this issue and the bounty. Let me know if you have additional scope, otherwise I think we can close this PR.

@ChuckHend Hello, this isn't my PR - I closed mine earlier.