search

tembo-io / pg_vectorize

The simplest way to build AI workloads on Postgres
https://tembo.io/pg_vectorize/
739 stars 33 forks source link

CONTRIBUTING.md: Clarify why the the setup mentions two different version of postgres to be used #179

Open palash25 opened 2 weeks ago

palash25 commented 2 weeks ago

I am assuming it is a typo but i just want to confirm this so I am creating an issue instead of a PR

The Apply configurations sections of the contributing guide asks to apply configurations to postgres version 15 <your-editor> ~/.pgrx/data-15/postgresql.conf

but when you run make setup the configurations are applied to version 17 which is hardcoded in the Makefile.

Is this is a mistake? the apply configurations step should either mention 17 as the postgres version or not mention any version at all and leave it up to the user. Thoughts?

ChuckHend commented 2 weeks ago

The guide could use more clarification. Pgrx let's us develop on multiple versions of postgres, but the default version in Cargo.toml is pg17. So those paths will change depending on which version you are trying to work on.

palash25 commented 2 weeks ago

i think it would be better to have something like ~/.pgrx/data-<pg-version>/postgresql.conf but its upto you. feel free to close the issue if you think otherwise.

ChuckHend commented 2 weeks ago

~/.pgrx/data-<pg-version>/postgresql.conf sounds good to me for the docs