temmy222 / PyTOUGHREACT

MIT License
6 stars 1 forks source link

JOSS Review - Python requirement version in docs #10

Closed blakeaw closed 6 months ago

blakeaw commented 6 months ago

This Issue has been raised as a part of the PyTOUGHREACT JOSS Review at: https://github.com/openjournals/joss-reviews/issues/6486

The Python version is given as >=3.7 in the README, but this is missing from the Dependencies section of the docs: https://pytoughreact.readthedocs.io/en/latest/dependencies.html

Instead, I see the following on my end: Python: pandas <https://pandas.pydata.org/> _ library Should that be something like Python: 3.7 or greater? Can you double-check?

blakeaw commented 6 months ago

I also see that there are specific versions for the other dependencies in the pyproject.toml: https://github.com/temmy222/PyTOUGHREACT/blob/master/pyproject.toml ; e.g., numpy>=1

However, these requirements aren't specified in the README or docs. It could be worth including those details in the Dependencies section of the docs.

temmy222 commented 6 months ago

Thanks for the comments. This has been corrected.