search

temoto / robotstxt

The robots.txt exclusion protocol implementation for Go language
MIT License
269 stars 55 forks source link

Regexp should match full string #25

Closed msama closed 4 years ago

msama commented 4 years ago

The current implementation of regexp matcher fails when the pattern is short and the url is long:

Allow: /$

Should not match with: /foo/ but only with /

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7c448ac). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   92.10%           
=========================================
  Files             ?        3           
  Lines             ?      304           
  Branches          ?        0           
=========================================
  Hits              ?      280           
  Misses            ?       13           
  Partials          ?       11
Impacted Files Coverage Δ
parser.go 91.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c448ac...18a0557. Read the comment docs.

temoto commented 4 years ago

Why?

temoto commented 4 years ago

Closing as silent. Feel free to continue any time.