Fix remote node availability check

tempesta-tech / tempesta-test

Test suite for Tempesta FW

11 stars 4 forks source link

Fix remote node availability check #293

Closed b3b closed 2 years ago

b3b commented 2 years ago

Can't run tests in isolated framework mode. For Python3, RemoteNode.wait_available is never completes successfully:

RemoteNode.run_cmd returns tuple of bytes, because subprocess stream is not in text mode: https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate
RemoteNode.wait_available bytes to str comparison b"check" != "check" is always False (was True for Py2)

b3b commented 2 years ago

One more fix added: ws tests was not started because of missed requests module.

RomanBelozerov commented 2 years ago

requests module is used in ws.test_ws_ping.CacheTest. It is disabled #1647. I run command

for i in `seq 40`; do ./run_tests.py ws.test_ws_ping.CacheTest.test_ping_websockets; done

I have all successful tests and don't have kernel panic in dmesg. What about you?

b3b commented 2 years ago

@RomanBelozerov It does not matter if ws.test_ws_ping.CacheTest is disabled. test_ws_ping module is imported anyway and tests run gives error if requests module is not installed:

======================================================================
ERROR: ws.test_ws_ping (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: ws.test_ws_ping
...
ModuleNotFoundError: No module named 'requests'```

This PR does not address #1647 issue

b3b commented 2 years ago

@RomanBelozerov In my setup for i in `seq 40`; do ./run_tests.py ws.test_ws_ping.CacheTest.test_ping_websockets; done complete with no panic.