search

tempesta-tech / tempesta-test

Test suite for Tempesta FW
11 stars 4 forks source link

read_chunked_body: fixed chunked body trailer parsing #294

Closed const-t closed 2 years ago

const-t commented 2 years ago

Now we try to determine end of chunked body before pass stream to parse_trailer and append the final CRLF to the body. When the final CRLF passed to parse_trailer, it will be dropped this implies chunked body without trailer will be invalid.

const-t commented 2 years ago

I'm not sure if that is related to this PR, but:

tempesta-nick tempesta-test (kt-fix-trailer-parse*?) # python3 -m unittest selftests.test_responses
.....F.
======================================================================
FAIL: test_equal (selftests.test_responses.ParseResponse)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test/selftests/test_responses.py", line 45, in test_equal
    self.assertFalse(self.trailer == self.o_trailer)
AssertionError: True is not false

----------------------------------------------------------------------
Ran 7 tests in 0.001s

FAILED (failures=1)

That test still fails on master, but it's also about trailers.

Looks like another problem, test dosn't work even without chunked trailer in parsed response.