search

tempesta-tech / tempesta-test

Test suite for Tempesta FW
10 stars 4 forks source link

Fix tests disabled after PR 1862 #441

Closed dmpetroff closed 1 year ago

dmpetroff commented 1 year ago

Pull request https://github.com/tempesta-tech/tempesta/pull/1862 has added mandatory checking of host-authority equality. That broke several tests that had been temporary disabled. Need to walk through that tests and update them for new tempesta-fw behavior

t_frang.test_host_required.FrangHostRequiredH2TestCase.test_disabled_host_http_required \
t_frang.test_host_required.FrangHostRequiredH2TestCase.test_h2_different_host_and_authority_header \
t_frang.test_host_required.FrangHostRequiredTestCase.test_disabled_host_http_required \
t_frang.test_host_required.FrangHostRequiredTestCase.test_host_header_missing \
t_http_rules.test_h2_http_rules.HttpRulesH2.test_scheduler
krizhanovsky commented 1 year ago

I mark this crucial since we should at least debug the tests before https://github.com/tempesta-tech/tempesta/pull/1862 is merged since the changes are subtle and we had enormous discussions on the pull request, so the final behavior should be clear for merging. Otherwise we might open a new issues similar to https://github.com/tempesta-tech/tempesta/issues/1630 during the tests development.

RomanBelozerov commented 1 year ago

CLosed as completed. #446