search

tempestphp / tempest-framework

The PHP framework that gets out of your way 🌊
https://tempestphp.com
MIT License
813 stars 55 forks source link

Finalize `NullShellExecutor` #259

Closed aidan-casey closed 1 week ago

aidan-casey commented 4 months ago

The NullShellExecutor is currently tested using mocks. This prevents us from making the class final.

We should revise the tests for that class and finalize the class.

Qupiter commented 3 months ago

Hey there, can you assign this issue to me and open a branch for it? I would like to work with you. This seems like a good issue to start with.

alibori commented 1 week ago

Hi @aidan-casey !

This issue can be closed, isn't it? If I'm right the NullShellExecutor class is final.

Thank you! 😃

aidan-casey commented 1 week ago

Hey, @alibori! It is final, but has no tests. We still need to refactor so we can test it. 🙂

brendt commented 1 week ago

No no, I fixed that, just forgot to close the issue