Resolve go path by using the configured SDK

katsadim commented 1 month ago

This change is based on https://github.com/templ-go/templ-jetbrains/issues/37#issuecomment-2361783706 and adds the configured Go SDK binary path in the inherited $PATH environment variable.

Note that:

By adding the org.jetbrains.plugins.go dependency on the plugin.xml, the plugin will only load when the Go plugin is installed in the IDE. More info here.
I had to change the intellij.type to GO for two reasons:
- The org.jetbrains.plugins.go plugin dependency could not be added to the platformPlugins list.
- This change allows the plugin to be theoretically installed in IntelliJ Community Edition as well.
I have only tested it in GoLand. This needs to be tested in other IDEs as well.

katsadim commented 1 month ago

no love for my PR?? :cry: :sob:

joerdav commented 1 month ago

Thanks @katsadim this is a great idea!

Sorry about the slow response, I was getting married haha!

This will be very useful and make onboarding much easier for goland users, I'll look at testing/releasing this at some point this week.

joerdav commented 1 month ago

Sorry, I've just realised my OSS maintainer license has expired for jetbrains! Just working on getting that back before I can test.

joerdav commented 1 month ago

This worked a treat for me, thanks!

katsadim commented 1 month ago

Thanks a lot @joerdav! And congrats on your marriage! Wishing you a lifetime of happiness!

templ-go / templ-jetbrains