search

templateflow / datalad-osf

Utility scripts to facilitate use of Datalad with OSF
Apache License 2.0
3 stars 4 forks source link

ENH: expose `limit_to_ext` param to control which files get written #2

Closed sappelhoff closed 4 years ago

sappelhoff commented 5 years ago

fixes #1 closes #4

This PR consists of three contributions. I suggest to click on the specific commits to review the diffs, because there are lots of cosmetic changes on top.

  1. expose a new parameter limit_to_ext to stop hardcoding that only nii.gz files get written. See: this diff: https://github.com/templateflow/datalad-osf/commit/79b83344c2ce33f4760f0b8931d34d80b4ad1455
  2. add a .gitignore file, see this diff: https://github.com/templateflow/datalad-osf/commit/49b3162e250226bd93af5ef48445cecd482c9243
  3. fix docstrings to adhere to numpy docstr style and fix pep8 issues, see this diff: https://github.com/templateflow/datalad-osf/commit/6c8859dbc2329d3c5b037453bed66ba043b8e920

Note: The PR preserves the previous behavior of datalad-osf (see https://github.com/templateflow/datalad-osf/pull/2/commits/27c5f907aefc985dba0d999549ec674c9feefb2d).

sappelhoff commented 5 years ago

@rciric have you seen this PR? What do you think?

sappelhoff commented 4 years ago

closing because it's stale. Feel free to reopen.

sappelhoff commented 4 years ago

@oesteban could you have a look at this one as well, please? :-)