Closed effigies closed 1 year ago
Since we're packaging the skeleton on every release, I'm +1 for switching to calver
Base: 85.98% // Head: 85.98% // No change to project coverage :thumbsup:
Coverage data is based on head (
b53762f
) compared to base (dd08432
). Patch has no changes to coverable lines.:exclamation: Current head b53762f differs from pull request most recent head e9e4b39. Consider uploading reports for the commit e9e4b39 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@mgxd Any preference of scheme? We could just do straight calver, e.g. YY.MM.DD
or YY.MM.PATCH
? Or keep with YY.MINOR.PATCH
to allow API change indicators?
No strong preference, but since we already have nipreps-versions
seems easier to just adopt YY.MINOR.PATCH
The
update_changes.sh
script was a bit out of date, but otherwise this looks in decent shape.@oesteban the API changes seem to justify a new minor release. I see in the release notes we at one point intended to switch to calver:
https://github.com/templateflow/python-client/blob/dd08432566c6acbdba20b98048606c6b054e67de/CHANGES.rst#L63
Should this be 23.0.0 instead? If you like I can update the build to use the nipreps-calver version scheme.