templateflow / python-client

A python client to query TemplateFlow via pyBIDS
https://templateflow.org/python-client/
Apache License 2.0
8 stars 12 forks source link

CI: Add manual trigger, bump action versions #113

Closed mgxd closed 8 months ago

mgxd commented 8 months ago

Preparation for a 24.0.0 release

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.41%. Comparing base (1e772fb) to head (6bed295). Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ========================================== + Coverage 87.37% 87.41% +0.04% ========================================== Files 6 6 Lines 301 302 +1 ========================================== + Hits 263 264 +1 Misses 38 38 ``` | [Flag](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | `87.41% <100.00%> (+0.04%)` | :arrow_up: | | [config](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | `59.27% <0.00%> (-0.20%)` | :arrow_down: | | [datalad](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | `80.46% <100.00%> (+0.06%)` | :arrow_up: | | [dls3](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | `63.57% <0.00%> (-0.22%)` | :arrow_down: | | [s3](https://app.codecov.io/gh/templateflow/python-client/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow) | `65.89% <0.00%> (-0.22%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=templateflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oesteban commented 8 months ago

we could manually fix this in _to_bibtex by adding a .replace(' http://dx.doi.org/', 'https://doi.org/')

Yup, that's a great idea

On Mon, Feb 26, 2024, 16:52 Mathias Goncalves @.***> wrote:

@.**** commented on this pull request.

In templateflow/tests/test_api.py https://github.com/templateflow/python-client/pull/113#discussion_r1502844307 :

@@ -14,30 +82,32 @@

mni2009_fbib = """\ @article{Fonov_2011, -\tdoi = {10.1016/j.neuroimage.2010.07.033}, -\turl = {https://doi.org/10.1016%2Fj.neuroimage.2010.07.033}, -\tyear = 2011, -\tmonth = {jan}, -\tpublisher = {Elsevier {BV}}, -\tvolume = {54}, -\tnumber = {1}, -\tpages = {313--327}, -\tauthor = {Vladimir Fonov and Alan C. Evans and Kelly Botteron and C. Robert \ -Almli and Robert C. McKinstry and D. Louis Collins}, -\ttitle = {Unbiased average age-appropriate atlases for pediatric studies}, -\tjournal = {{NeuroImage}} +DOI={10.1016/j.neuroimage.2010.07.033}, +url={http://dx.doi.org/10.1016/j.neuroimage.2010.07.033},

@oesteban https://github.com/oesteban yup, i'm not sure why crossref is regressing (again)...

$ curl -LH "Accept: application/x-bibtex; charset=utf-8" https://doi.org/10.1016/j.neuroimage.2010.07.033

@article{Fonov_2011, title={Unbiased average age-appropriate atlases for pediatric studies}, volume={54}, ISSN={1053-8119}, url={http://dx.doi.org/10.1016/j.neuroimage.2010.07.033}, DOI={10.1016/j.neuroimage.2010.07.033}, number={1}, journal={NeuroImage}, publisher={Elsevier BV}, author={Fonov, Vladimir and Evans, Alan C. and Botteron, Kelly and Almli, C. Robert and McKinstry, Robert C. and Collins, D. Louis}, year={2011}, month=jan, pages={313–327} }

we could manually fix this in _to_bibtex by adding a .replace(' http://dx.doi.org/', 'https://doi.org/')

— Reply to this email directly, view it on GitHub https://github.com/templateflow/python-client/pull/113#discussion_r1502844307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESDRW2L7A6VY5RKDDI4GDYVSVVNAVCNFSM6AAAAABDVTV3X6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBRGI2TGNBTGU . You are receiving this because you were mentioned.Message ID: @.***>