templateflow / python-client

A python client to query TemplateFlow via pyBIDS
https://templateflow.org/python-client/
Apache License 2.0
8 stars 12 forks source link

ENH: Run an automatic skeleton update on import by default #45

Closed mgxd closed 4 years ago

mgxd commented 4 years ago

closes #44

codecov[bot] commented 4 years ago

Codecov Report

Merging #45 into master will increase coverage by 0.28%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   88.05%   88.34%   +0.28%     
==========================================
  Files           5        5              
  Lines         201      206       +5     
==========================================
+ Hits          177      182       +5     
  Misses         24       24              
Flag Coverage Δ
#api 88.34% <100.00%> (+0.28%) :arrow_up:
#config ?
#datalad 78.64% <92.30%> (+0.03%) :arrow_up:
#dls3 55.82% <76.92%> (+14.03%) :arrow_up:
#s3 59.22% <76.92%> (+4.99%) :arrow_up:
Impacted Files Coverage Δ
templateflow/__init__.py 100.00% <100.00%> (ø)
templateflow/conf/__init__.py 91.30% <100.00%> (ø)
templateflow/conf/_s3.py 97.91% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1ee264...ea7dd5c. Read the comment docs.

oesteban commented 4 years ago

Bumping this up, any updates?

oesteban commented 4 years ago

This is ready, correct?

mgxd commented 4 years ago

yes - update is still disabled by default when using datalad. do we want to revert that now that #48 is in?

oesteban commented 4 years ago

Nope, datalad users are supposed to be knowledgeable enough to call update() themselves 👍 . Merging!! thanks for this :)

oesteban commented 4 years ago

With this merged, we should cut a new release, DYT?

oesteban commented 4 years ago

I'll go for it