search

templateflow / python-client

A python client to query TemplateFlow via pyBIDS
https://templateflow.org/python-client/
Apache License 2.0
8 stars 12 forks source link

BF: provide path to the dataset as "dataset" argument #48

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago

this is due to the change in behavior of 0.12.x series of DataLad. See https://github.com/datalad/datalad/issues/3759 for more info

Closes #47 Disclaimer: I have not tried the fix anyhow

oesteban commented 4 years ago

I guess this PR should also include an update to:

https://github.com/templateflow/python-client/blob/ca302ad88cac860fd7848581937954f1a46c6a41/setup.cfg#L49

I guess:

    datalad ~= 0.12.0
codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will decrease coverage by 0.99%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   88.05%   87.06%   -1.00%     
==========================================
  Files           5        5              
  Lines         201      201              
==========================================
- Hits          177      175       -2     
- Misses         24       26       +2
Flag Coverage Δ
#api 87.06% <100.00%> (-1.00%) :arrow_down:
#config 52.23% <100.00%> (-1.00%) :arrow_down:
#datalad 77.61% <100.00%> (-1.00%) :arrow_down:
#dls3 41.79% <0.00%> (ø)
#s3 54.22% <0.00%> (ø)
Impacted Files Coverage Δ
templateflow/conf/__init__.py 86.95% <100.00%> (-4.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca302ad...13e0217. Read the comment docs.

yarikoptic commented 4 years ago

done

oesteban commented 4 years ago

Thx!