templateflow / python-client

A python client to query TemplateFlow via pyBIDS
https://templateflow.org/python-client/
Apache License 2.0
8 stars 10 forks source link

``BIDSLayout`` is now including dotfolders (i.e., `.git`, `.datalad`, etc.) #98

Closed oesteban closed 1 year ago

oesteban commented 2 years ago

For some reason, it seems they have started to be included. Any ideas @effigies @mgxd ?

mgxd commented 2 years ago

Can you share a minimal example? I wasn't able to verify this using the latest pybids

oesteban commented 2 years ago

You'll need templateflow in datalad mode

oesteban commented 2 years ago

or manually stick one dotfolder of your own and then query that particular template where you inserted the dotfolder

oesteban commented 2 years ago

I am suspicious that this https://github.com/templateflow/python-client/blob/53674989b3a95364b4b03b3b0136e99b50970b08/templateflow/conf/__init__.py#L153-L160 will only check for these folders at the root of the path.

mgxd commented 2 years ago

I think that is intended, based on the docstring. They should probably be converted to regex

oesteban commented 2 years ago

Yes, I didn't mean this is a PyBIDS issue