templateflow / tpl-MNI152NLin2009cAsym

MNI152NLin2009cAsym
Other
8 stars 8 forks source link

git-annex branch wasn't pushed #1

Closed yarikoptic closed 5 years ago

yarikoptic commented 5 years ago

AFAIK datalad publish should have pushed it...

yarikoptic commented 5 years ago

the same issue in https://github.com/templateflow/tpl-fMRIPrep/

oesteban commented 5 years ago

I didn't datalad publish, so my mistake.

I kind of assumed that will actually upload files to their respective location?

for the case of tpl-fMRIPrep I'm aware that it is not in a sane state.

oesteban commented 5 years ago

I guess this is not okay... https://github.com/templateflow/tpl-MNI152NLin2009cAsym/compare/git-annex?expand=1

yarikoptic commented 5 years ago

I kind of assumed that will actually upload files to their respective location?

upload files? you mean to github? it doesn't support "hosting of git-annex'ed files", so no files would be uploaded here. I assume that you added those files to git-annex while pointing urls to OSF, so that is where they would be fetched from by git annex when ppl would clone this repo locally and issue "git annex get" or "datalad get" commands

yarikoptic commented 5 years ago

I guess this is not okay... https://github.com/templateflow/tpl-MNI152NLin2009cAsym/compare/git-annex?expand=1

why do you think so? just seems to mark existence of a clone ( your local one?) where those files are present

yarikoptic commented 5 years ago

so - branch is here... and I see that you did use --relaxed mode which caused files to be added to "URL backend" which doesn't do checksuming... I would recommend to redo without --relaxed, so files get downloaded and added to proper backend with checksum (MD5 in this case , since datalad was used to create and look into .gitattributes for default backend)

oesteban commented 5 years ago

@rciric have we solved this problem with your latest updates?

yarikoptic commented 5 years ago

I think so (at least for the latest version of things):

hopa:/tmp
$> datalad install -g https://github.com/templateflow/tpl-MNI152NLin2009cAsym
[INFO   ] Cloning https://github.com/templateflow/tpl-MNI152NLin2009cAsym [1 other candidates] into '/tmp/tpl-MNI152NLin2009cAsym' 
[INFO   ]   Remote origin not usable by git-annex; setting annex-ignore          
install(ok): /tmp/tpl-MNI152NLin2009cAsym (dataset)
action summary:                                                                                 
  get (ok: 25)                                                                                   
  install (ok: 1)                                                                                
datalad install -g https://github.com/templateflow/tpl-MNI152NLin2009cAsym  10.07s user 2.27s system 67% cpu 18.202 total