templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
86 stars 15 forks source link

Editor Buttons does not work properly in frontend #146

Open Giorgi625 opened 2 years ago

Giorgi625 commented 2 years ago

I use JCE editor and it show below editor buttons: Article, Contact, Field, Media, Menu, Module, Page Break, Read more (I mean buttons whish are displayed by editors-xtd plugins) When I add article from backend and click on one of the buttons it show modal window with details for each button, but on frontend instead of modal window it opens new page whish shows information but has errors like terrible design, now save or close buttons and so on. So what I noticed is strange because when I use TinyMCE this buttons work in Astroid, but when I used Cassiopeia and JCE Editor then this also works. So there is problem between JCE and Astroid

Chacapamac commented 2 years ago

I @Giorgi625 — I use also JCE. When you talk about the button your probably talking about the “Joomla Editor button” in JCE to inserts Joomla elements. Screen Shot 2022-06-29 at 12 13 28 PM

I test on two websites, one live and one local

WebSite 1 efoilsurf Live Test —> http://www.efoilsurf.graf-test.ca/index.php/en/ Joomla 3.10.9 JCE Editor Pro 2.9.27 Astroid Framework/tempates zero/one 2.5.16 On Template Zero

WebSite 2 Local Map website Joomla 3.10.10 JCE Editor Pro 2.9.27 Astroid Framework 2.5.18 — tempates zero/one 2.5.16 On Template One

ASTROID PLUGIN ON BOTH astroid-plugin


Bug 1

An error happen almost each time you hover a frontend module editing icon (doesn't happen on Article frontend edit link)

Error: Uncaught TypeError: can't access property "template", this._config is null getTipElement http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _cleanTipClass http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 hide http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _ http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 a http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 s http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 b http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 setTimeout handler*b http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _queueCallback http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 hide http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _leave http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _setListeners http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 t http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 i http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 N http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 on http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _setListeners http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 _setListeners http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 un http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 getOrCreateInstance http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 jQueryInterface http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 jQuery 2 jQueryInterface http://www.efoilsurf.graf-test.ca/media/astroid/assets/vendor/bootstrap/js/bootstrap.bundle.min.js?v=2.5.16:6 mouseenter http://www.efoilsurf.graf-test.ca/templates/astroid_template_zero/js/system/frontediting.js?63d0f8ee2ac930c754b6a812e17fbc3d:127 jQuery 3 3 bootstrap.bundle.min.js:6:63482

Module Edit Link = error efoil-module

Article Edit Link - no problem Article-edition


Bug 2 JCE Joomla Editor have problems in frontend opening of the **JCE Joomla insert buttons No problems at all in backend

WebSite 1 and Website 2 • In modules and article frontend editing —Try insert an article by JCE Joomla insert button ( given by NoNumber ArticleAnywhere) — I get this console error and the following error in the frontal edition lightbox articleanywhereerror

Console error: 12:32:20.107 GEThttp://www.efoilsurf.graf-test.ca/index.php/en/?rl_qp=1&folder=plugins.editors-xtd.articlesanywhere&file=popup.php&name=jform_content [HTTP/1.1 500 Internal Server Error 285ms]

Lightbox error: 0 - Return value of Astroid\Framework::getTemplate() must be an instance of Astroid\Template, null returned

• I try with the Joomla Native article insertion in frontend and it work correctly


I also experience some problems with the layout and modules rendering when editing in frontend?? When frontend editing an Article (modules OK?) The edition work well but I see problems with the surrounding interface Example: I have 3 well known Smartslider module that are disappearing from the interface to show only their system calling code — like —> “smartslider3[71]“???


@Giorgi625 can you send more infos, screenshots, I like to recreate the problem...

Giorgi625 commented 2 years ago

I recorded video where everything can be seen clearly https://youtu.be/2v9589jDwLM

Chacapamac commented 2 years ago

Ok, now I see what you mean. @Giorgi625 .. I mark it as a bug

What I show on top are bugs with Joomla 3 frontal edition vs Astroid. — I was also using the JCE tool “Joomla Editor buttons(Also available on 4) that automatically disables the Joomla edition toolbar that you were using.

Screen Shot 2022-06-29 at 5 25 23 PM

Note: Even on Joomla 4 that tool seem to work a bit better compare to the Joomla Toolbar that doesn't work at all.

I test on my live last update Joomla 4 test site with the last Astroid Framework and the last Astroid Template Zero (and I try also Template One (Same bug)

You right @Giorgi625, I experience the same problems when using the Joomla Toolbar. — Not opening in a lightbox, icons are missing — In fact it's totally unusable.

Work perfectly on Cassiopea

I get This error message when opening the frontend edition:

17:56:21.821 Uncaught TypeError: Joomla.initialiseModal is not a function
    connectedCallback http://joom4-astro.graf-test.ca/media/system/js/fields/joomla-field-media.min.js?b9214e72c06daafd562e5c4116292b5763a437fe:1
    <anonymous> http://joom4-astro.graf-test.ca/media/system/js/fields/joomla-field-media.min.js?b9214e72c06daafd562e5c4116292b5763a437fe:1
joomla-field-media.min.js:1:3102

I also get also other errors and warning...

17:58:30.455 GEThttp://joom4-astro.graf-test.ca/media/jui/js/bootstrap.min.js?0df6e4ff0b6fe87ec8ab67d2b549936a
[HTTP/1.1 404 Not Found 37ms]

17:58:30.504 The resource from “http://joom4-astro.graf-test.ca/media/jui/js/bootstrap.min.js?0df6e4ff0b6fe87ec8ab67d2b549936a” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff). index.php

17:58:30.806 GEThttp://joom4-astro.graf-test.ca/favicon.ico
[HTTP/1.1 404 Not Found 6ms]
Giorgi625 commented 2 years ago

There maybe more errors in Frontend submit form. I think this needs more investigation. I noticed with TinyMCE this buttons work, but I have not seen person who liked TinyMCE. I am pretty sure most users use JCE instead of TinyMCE.

Chacapamac commented 2 years ago

To me JCE is the top editor in Joomla. Even better than those drag & Drop Editor, with the columns and templates, styles and all other possibilities you can go wrong. On top of that, it can easily become a total WYSIWYG Anyway I test all the big drag & drop last year and went back to JCE. Astroid need to work wit JCE.

sonvnn commented 2 years ago

@Giorgi625 Thanks for report issue. I fixed this issue in https://github.com/templaza/astroid-framework/commit/2a4c6d3cdc00e63cfc8b5718bbe4124d4a694a69

Please help me check it!

Thanks & Best Regards, Sonny

Chacapamac commented 2 years ago

@sonvnn - I like to test but with the version of 2.5.18 framework+Templates on Github I get the same problems. Not sure where to download the last framework and template?

Willing to test but, I’m not a pro of Github, just need to know what to do (where to download) the modified package when you do an edit?

sonvnn commented 2 years ago

Screen Shot 2022-08-04 at 11 14 58 @Chacapamac I test JCE with Joomla 3 and Joomla 4 without any issue. My JCE version is free version. I am not sure about Pro version. May you send me one? I will test it on my local.

Best Regards, Sonny

Chacapamac commented 2 years ago

@sonvnn I send you that by email now!

You didn’t answer my question

Willing to test but, I’m not a pro of Github, just need to know what to do (where to download) the modified package when you do an edit?

I want to be sure, I’m testing with the right code update...

Chacapamac commented 2 years ago

@sonvnn , did you receive my JCE file?

sonvnn commented 2 years ago

@Chacapamac Not yet bro. May you resend JCE to sonlv@templaza.com?

Thank you.

Chacapamac commented 2 years ago

@sonvnn — I just send you the Google Drive link to the archive with both JCE Pro and JCE Mediabox installer. SVP UNZIP FIRSTYou will have both JCE Pro Joomla installer and JCE Mediabox installer

Sorry to send by Google Drive, my mailing server keep return my mail with the same attachments for some security reason???

Good Day!

Chacapamac commented 1 year ago

@sonvnn & @Giorgi625 This is not JCE related

I test on my testing website here with the onboard Editor TinyMce —> http://joom4-astro.graf-test.ca

First I try to Frontend edit my Home Article Screen Shot 2023-01-02 at 5 21 39 PM

• When I click the frontend “Edit” link I get this error in console frontend-edit-error

• After when I try to insert Joomla content ( CMS Content ) I try “Joomla Articlecms-content

I get these errors in console — Not in Lightbox errors

• If I try to Add a Joomla Contact — Errors in Lightbox contacts

• If I try to Add a Joomla Field — Errors in Lightbox fields

• If I try to Add a Joomla Media — Work OK but seem to enter 2 times

• If I try to Add a Joomla Menu — Errors in Lightbox menu

• If I try to Add a Joomla Links — Work OK but seem to enter 2 times the link item

• If I try to Add a Joomla Module — Work OK but seem to enter 2 times the module code

Check for the other errors...

Remarks: — It seem to work without errors if you try again on a previous Joomla items — It seem to be off and on — Not Stable

I can provide you with the Admin keys