templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
80 stars 13 forks source link

[2.5.7] Responsive settings are ignored after upgrade from 2.5.4 #17

Closed FrankReisenhofer closed 2 years ago

FrankReisenhofer commented 2 years ago

Today I updated from 2.5.4 to 2.5.7.

After this upgrade the responsive settings for a layout element seem to be ignored.

The settings are like:

image

But this settings are completely been ignored and the element is also shown on large and extra-large screens.

Any ideas what might cause this?

sonvnn commented 2 years ago

Thanks for feedback! I will check this issue in the next 24h. Please wait for update.

Thanks, Sonny

Joomlaplates commented 2 years ago

Yes, I can agree, its a bug. There is a missing css class in the PHP code and a missing css code in the css file.

@media (min-width: 1400px) { 
  .hideonxxl {
    display: none !important;
  }
}

hide

sonvnn commented 2 years ago

Hello @FrankReisenhofer @Joomlaplates Thanks for your support. I fixed this issue at #18 Please help me check it again. I will update version 2.5.8 as soon as you confirm that issue was solved.

Best Regards, Sonny

FrankReisenhofer commented 2 years ago

Hello @sonvnn,

Thanks for your quick fix.

I am ready to perform some tests once the new version is released.

sonvnn commented 2 years ago

Hello @FrankReisenhofer You can download Master branch at https://github.com/templaza/astroid-framework/archive/refs/heads/master.zip Let's upload to your site -> clear template cache and check it. Please let me know if your issue still happen.

Best Regards,

FrankReisenhofer commented 2 years ago

Hello @sonvnn

I installed the master branch version.

But it is not yet working:

Please have a look at [1]. You will still see two slideshows.

[1] https://reisenhofer.de/index.php/de/

sonvnn commented 2 years ago

Hi @FrankReisenhofer ,

You should try to enable "Hide on Extra-Extra-Large Devices" in Responsive tab. Screen Shot 2021-11-09 at 17 42 19 Please see my image.

FrankReisenhofer commented 2 years ago

Hello @sonvnn ,

That are exactly my settings for this field :-). See my first screenshot.

As I have currently no further time for performing tests I installed again version 2.5.4.

-> The side is back to normal.

In the future I will wait for green light from @Joomlaplates before installing a newer version.

vtheod commented 2 years ago

May I ask who is supporting Astroid? Templaza or Joomlaplates?

Joomlaplates commented 2 years ago

Both are supporting Astroid, but Templaza is creating the Gits and update the files. Otherwise it gets confused, if both are working on files.

vtheod commented 2 years ago

That's clear enough. Thanks!

Joomlaplates commented 2 years ago

Hello @sonvnn ,

That are exactly my settings for this field :-). See my first screenshot.

As I have currently no further time for performing tests I installed again version 2.5.4.

-> The side is back to normal.

In the future I will wait for green light from @Joomlaplates before installing a newer version.

Not a bad idea! We are still testing the Version 2.5.7 and ofc there are still some bugs. https://www.joomlaplates.de/forum/news-updates-und-informationen/117-astroid-2-5-7-changelog.html

sonvnn commented 2 years ago

Hello @FrankReisenhofer I mean you missed XXL option. You have to go to your layout configure and enable "Hide on Extra-Extra-Large Devices". I just added this in latest version. Screen-Shot-2021-11-10-at-09 38 15

Joomlaplates commented 2 years ago

I can agree, the hideonxxl is working now. Maybe enable the debug function in astroid plugin to delete the cache and compile the scss again

sonvnn commented 2 years ago

Yeah, You need clear template cache to re-compile scss again. screenshot-joomla templaza com-2021 11 10-16_19_26

sonvnn commented 2 years ago

This issue was resolved at #18
Please help me update Astroid v2.5.8. Thank you :)

FrankReisenhofer commented 2 years ago

Hello @sonvnn ,

Thanks for your information. I updated to 2.5.8 and can confirm:

After using the xxl option correctly the side is back to normal :-).