templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
78 stars 12 forks source link

Astroid 3.0.0 big problem with google fonts #398

Closed WM-Loose closed 9 months ago

WM-Loose commented 9 months ago

Hi Sonny,

the headings for the fonts are missing in the typography. It no longer shows whether it is system, custom or google fonts. That's not possible and is a huge problem, at least in Europe. Please fix it as soon as possible. We have to see what google fonts are.

WM-Loose commented 9 months ago

One more: The graphical representation of the font and font size is also not always displayed under the input fields.

WM-Loose commented 9 months ago

Astroid 2 vorher

Astroid 3 nachher

deltapapa01 commented 9 months ago

Hi Dirk, I know what you mean. I had already reported this somewhere here when testing, but this has gone a bit under. You write that it is a big problem, but in the frontend everything is displayed okay, right? So purely from the implementation of the GDPR. But I am also of your opinion that the representation in the combo box should be divided and displayed a little better.

WM-Loose commented 9 months ago

The fonts will not be changed after the update and will also be loaded locally as previously set. That's not what it is about. The point is that if you want to change the font, you can no longer find a heading in the template options. The division into custom fonts and google fonts is missing. If a user accidentally selects a Google font, this is not permitted by the GDPR in Europe and can have dire consequences for the website owner. Until this is resolved by Sonny, we cannot update to Astroid 3.

The visual display of the selected font is also completely missing. These 2 essential things must work, otherwise the framework is not really usable.

sonvnn commented 9 months ago

@WM-Loose @deltapapa01 I fixed this issue in https://github.com/templaza/astroid-framework/pull/407/commits/232edae4e0556f7397b4ef387ad6d73cebd5c148 Please help me download v3 branch and re-test again.

The screen will look like this Screen Shot 2023-10-18 at 16 32 22

PS: @WM-Loose I created a topic since September 8th, 2023 here #388 . I am happy if you can join us for testing Astroid before new version release in the future. It will help us avoid issues like that arise when the latest version is released

Thanks & Best Regards, Sonny

WM-Loose commented 9 months ago

This looks very good. When can you deploy this in version 3.0.2?

Joomlaplates commented 9 months ago

Hi all, its working now with local fonts in Astroid 3.0.1 Ofc the preview would be good. Regards, Peter

deltapapa01 commented 9 months ago

Hi @sonvnn , i test v3 branch 10/18/23 on J4.4.0, but the combo box is not there:

image

and i have some error in browser console: image

If you net admin access, please let me know, i test it on my live site here: petersen-webdesign.de

deltapapa01 commented 9 months ago

Mhhh, thats crazy, on my testsite with 4.3.4 the V3 branch version works fin. I update to 4.4.0 on my testsite, it works fine too. I don't know, why it works not on my live site.

But I also had a very strange problem: I made an Akeeba backup from my test site with Joomla 4.3.4, with Astroid V3.0.1. Then I pulled the backup to my live - page, because I had an error with my backup yesterday evening. Well, after I had started the Joomla then on my live side, I had again this error `File: /html/petersen-webdesign/libraries/astroid/framework/article.php Line: 266 Message: Call to a member function getRelatedArticles() on null

0 /html/petersen-webdesign/templates/astroid_template_zero/html/com_content/article/default.php(214): AstroidFrameworkArticle->renderRelatedPosts()

1 /html/petersen-webdesign/libraries/src/MVC/View/HtmlView.php(410): include('...')

2 /html/petersen-webdesign/libraries/src/MVC/View/HtmlView.php(203): Joomla\CMS\MVC\View\HtmlView->loadTemplate(NULL)

3 /html/petersen-webdesign/components/com_content/src/View/Article/HtmlView.php(244): Joomla\CMS\MVC\View\HtmlView->display(NULL)

4 /html/petersen-webdesign/libraries/src/MVC/Controller/BaseController.php(645): Joomla\Component\Content\Site\View\Article\HtmlView->display()

5 /html/petersen-webdesign/components/com_content/src/Controller/DisplayController.php(121): Joomla\CMS\MVC\Controller\BaseController->display(true, Array)

6 /html/petersen-webdesign/libraries/src/MVC/Controller/BaseController.php(678): Joomla\Component\Content\Site\Controller\DisplayController->display()

7 /html/petersen-webdesign/libraries/src/Dispatcher/ComponentDispatcher.php(143): Joomla\CMS\MVC\Controller\BaseController->execute('...')

8 /html/petersen-webdesign/components/com_content/src/Dispatcher/Dispatcher.php(56): Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch()

9 /html/petersen-webdesign/libraries/src/Component/ComponentHelper.php(361): Joomla\Component\Content\Site\Dispatcher\Dispatcher->dispatch()

10 /html/petersen-webdesign/libraries/src/Application/SiteApplication.php(208): Joomla\CMS\Component\ComponentHelper::renderComponent('...')

11 /html/petersen-webdesign/libraries/src/Application/SiteApplication.php(249): Joomla\CMS\Application\SiteApplication->dispatch()

12 /html/petersen-webdesign/libraries/src/Application/CMSApplication.php(293): Joomla\CMS\Application\SiteApplication->doExecute()

13 /html/petersen-webdesign/includes/app.php(61): Joomla\CMS\Application\CMSApplication->execute()

14 /html/petersen-webdesign/index.php(32): require_once('...')

15 {main}

`

Although I had not before on my test side. Is everything on the same server.

I have then updated to Joomla 4.4, and here now problems with the fonts in the V3 Branch version. This problem I have in the identical test version not...

sonvnn commented 9 months ago

Please clear cache browser. @deltapapa01

sonvnn commented 9 months ago

@deltapapa01 Please update Joomla 4.4. Then the error will disappear. This issue is available for Joomla 4.3

WM-Loose commented 9 months ago

Hi Sonny, the distribution of fonts for selection is now really great. The view of the fonts under the fields is still missing in Astroid 3.0.2. Can you already say when you can show this again?

preview