search

templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
83 stars 13 forks source link

module-title class is not available anymore #503

Closed Joomlaplates closed 9 months ago

Joomlaplates commented 9 months ago

Hello Sony, since you changed the html override (astroidxhtml.php) the module-title class is not available anymore. Can you add the class again to framework/html/layouts/chromes/astroidxhtml.php Or is there a reason why you delete this class from astroidxhtml.php file? Regards Peter

sonvnn commented 9 months ago

@Joomlaplates Do you mean header-class? It is still here. Screen Shot 2023-12-13 at 14 33 11

https://github.com/templaza/astroid-framework/blob/master/framework/html/layouts/chromes/astroidxhtml.php#L26

Screen Shot 2023-12-13 at 14 36 12

Please tell me if you I mis-understand something.

Best Regards, Sonny

Joomlaplates commented 9 months ago

Hello Sony, yes youre right! But before the class was set automatically to module-title $headerClass = $headerClass ? ' class="module-title ' . htmlspecialchars($headerClass, ENT_COMPAT, 'UTF-8') . '"' : ' class="module-title"'; Anyway, if I can add the class manually, so there is no problem. I just wanne know why you removed the module-title class. Regards Peter

sonvnn commented 9 months ago

@Joomlaplates Ahh Okay! I understand 👍 I re-add module-title to module layout here https://github.com/templaza/astroid-framework/commit/9ad69f7b5e9f8942d4697cc3d975f9708a10cc35

Please help me test and confirm if it works. I will soon release new version :)

Best Regards, Sonny

sonvnn commented 9 months ago

@Joomlaplates I just copy source file from Joomla core to replace old version, LOL. But no worry! I re-added 'module-title' again. You can download v3 and retest again. I think It should work :)

Joomlaplates commented 9 months ago

Hi Sony, yes it works! Thanks, friendly regards