templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
77 stars 12 forks source link

meta generator displays on 404 pages #556

Open SerGun78 opened 4 months ago

SerGun78 commented 4 months ago

When you enable the meta tag removal plugin in Astroyd, it is still shown on the error pages.

opera_NOFPoqhmcY

opera_Ez4DLUJ876

salahjaafar commented 4 months ago

Please publish the displayed error so that we can better understand the situation and find an appropriate solution.

sonvnn commented 4 months ago

Thanks! I will check it. May be a bit slowly because I am in Lunar New Year holiday.

sonvnn commented 4 months ago

May you send me your admin account via sonlv@templaza.com? I will help you check it.

SerGun78 commented 4 months ago

Sonny, hi. Unfortunately, I cannot give access. Why give it? You can check it yourself. Enable hiding the Joomla meta tag in the Astroyd plugin, and then go to the error page and check its code.

Giorgi625 commented 4 months ago

It is normal practic to give access to developer to check it, because for example on my website when I enable in plugin to hide generator it works just fine. so most probably there is some problem on your website so he should have possibility to check what is wrong. noname

you can simply create temporary user for him and after he fixed it disable that user. I also gave him my user for one of my websites because there is problem with temptate which is not on other websites.

SerGun78 commented 4 months ago

Giorgi625, can I have a screenshot from your error page?

SerGun78 commented 4 months ago

But what does the error page itself look like in the frontend? It seems to me that you did not send the code of the error page, but the existing one. by default it looks like this: opera_SKk73VenRh

and her code is like this: opera_V8IYRiRm5i

Giorgi625 commented 4 months ago

Yes I missed that you were reporting problem for error page, but as you can see I do not have problem on error page either.

noname

SerGun78 commented 4 months ago

Astroid 3.0.10? I found this error on 3.0.9. ONE 3.0.8

Giorgi625 commented 4 months ago

Yep Framework Version: 3.0.10 Template Two Version: 1.0.2

SerGun78 commented 4 months ago

All clear. So Sonny made changes in 3.0.10, but it's not in the version history.

Giorgi625 commented 4 months ago

I checked on another site with 3.0.9 and I do not see generator tag there too.

SerGun78 commented 4 months ago

Now I have updated to 3.0.10. Now everything is fine, there is no joomla meta tag in the error page code. On the error page itself the font size and buttons have also changed. was: opera_SKk73VenRh became: opera_ht5RYPcuiG

Why was this done?

The font size should remain the same as on the entire site in the typography settings! How can I change it now? And the size of the button too. It was better, uniform, the same. And now the error page is stylistically different.

SerGun78 commented 4 months ago

I checked on another site with 3.0.9 and I do not see generator tag there too.

check on template "one"

Giorgi625 commented 4 months ago

yes I see meta generator on template one when in plugin it is disabled.

SerGun78 commented 4 months ago

it means there was an error. Sonny cleaned up heavily in error.php the meta tag has disappeared, but visually the error page itself is now different from the working pages of the site. You can't do that.

rolled back to 3.0.9 I haven't seen the benefits yet. All widgets can be made using bootstrap. Widgets, on the contrary, overload astroid