search

templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
83 stars 13 forks source link

Added CDN and Local js files options to Fontawesome load #598

Open uzielweb opened 6 months ago

Chacapamac commented 6 months ago

Is this 300 files added for have the ability to load Awesome Locally? Not sure if it’s a good idea to include all these files. Include the ability for users to switch to local Icons, Yes, but, like the Custom Local fonts, they should install them manually, only if they need them.

Can somebody explain why?

uzielweb commented 6 months ago

Custom SVGs are used for Font Awesome instead of traditional fonts when utilizing JS Local FontAwesome These SVGs are loaded individually, for instance, when you use the code , it gets dynamically replaced on-the-fly with the actual SVG code during runtime. Is better that load entire fonts to show only "2 or more" icons by page. Local fonts are not "installed" in the user computer, but loaded in a single time for session. Local SVG are loaded in every connection by session individually instead entire font files.

Chacapamac commented 6 months ago

@uzielweb Seem to be a good thing, I guess it’s probably easy to implement, a bit like “Custom Local Fonts”? — Downloads the SVGs — Download a JS file and link and load all that

Its probably a good reason why the merging of this is block? What you think is the problem, Size, maintenance of the libraries, usability?

uzielweb commented 6 months ago

OK, so optional dowload svg package is a good idea too, but offer CDN JS uses zero megabytes in the package, I thing. This is an idea.