templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
77 stars 12 forks source link

Trying inserting Favicons by the Favicon Astroid settings. Doesnt Work? #617

Open Chacapamac opened 3 months ago

Chacapamac commented 3 months ago

I create my icons at —> https://realfavicongenerator.net/

• I insert the files generated in a sub-folder to the root (e.g. “my-favicon”) with the “site.webmanifest” file and all images in.

Screen Shot 2024-03-24 at 10 15 18 AM

Note: remark the frontal backslash on the Astroid generated example when you said “Can be a relative path e.g. (manifest.json) e.g. (site.webmanifest) with no leading slash (/)” — Is this misleading?

— I insert and try both my-favicon/site.webmanifest and /my-favicon/site.webmanifest

It is not working?

• If I take the “Custom Code” route, it work perfectly e.g.

<!-- favicon links codes--> 
<link rel="apple-touch-icon" sizes="180x180" href="/my-favicon/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/my-favicon/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/my-favicon/favicon-16x16.png">
<link rel="manifest" href="/my-favicon/site.webmanifest">
<link rel="mask-icon" href="/my-favicon/safari-pinned-tab.svg" color="#5bbad5">
<link rel="shortcut icon" href="/my-favicon/favicon.ico">
<meta name="msapplication-TileColor" content="#da532c">
<meta name="msapplication-config" content="/my-favicon/browserconfig.xml">
<meta name="theme-color" content="#ffffff">
sonvnn commented 3 months ago

I fixed this issue in https://github.com/templaza/astroid-framework/commit/887653d77cdd6771a32870f8aba68f84a8c3307e

Please help me check it. Best Regards, Sonny

Chacapamac commented 3 months ago

What code should I use to test?

my-favicon/site.webmanifest or /my-favicon/site.webmanifest

“my-favicon” is a folder in the root

sonvnn commented 3 months ago

What code should I use to test?

my-favicon/site.webmanifest or /my-favicon/site.webmanifest

“my-favicon” is a folder in the root

Sorry for late reply. You can use "my-favicon/site.webmanifest"