templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
77 stars 12 forks source link

Since 3.0.12 Error > Attempt to modify property "links" on false #623

Closed Joomlaplates closed 2 months ago

Joomlaplates commented 3 months ago

After update the Astroid to 3.0.12 I got an error when i want to setup the Template settings

Joomla 5.0.3 and PHP 8.3 Attempt to modify property "links" on false Bildschirmfoto2024-03-28um15 36 07

Anybody know what it is? Thanks

sonvnn commented 3 months ago

It's problem from Menu Assignment. I will release a quick fix on Monday. Solution is revert to 3.0.11

sonvnn commented 3 months ago

Hi @Joomlaplates

May you send me your admin account? I need check it on your server.

Thanks & Best Regards, Sonny

Joomlaplates commented 3 months ago

With V3 Astroid I still got the issue issue

sonvnn commented 3 months ago

May you send me the admin of your site? I will check it.

Best regards, Sonny

Joomlaplates commented 3 months ago

I have send you already! Now again

RedesMexico commented 3 months ago

I have the same error with version 3.0.12, can I collaborate?

Following "sonvnn", I have executed the 36 additions and 34 deletions of the Helper.php file. However the error remains the same.

sonvnn commented 3 months ago

I have send you already! Now again

I am sorry! I still haven't received your email yet. Can you send me again via sonlv@templaza.com?

@RedesMexico Yes, please send me your admin account via sonlv@templaza.com. I will help you check it.

sonvnn commented 3 months ago

@Joomlaplates @RedesMexico I added some conditions to handle exceptions of Menu Links at https://github.com/templaza/astroid-framework/commit/85f437c367f11ce528610e3475ef8623b8930002. Please help me download v3-branch and retest it.

As soon as you confirm this issue gone. I will release v3.0.13

RedesMexico commented 3 months ago

Ok I will test again with the new changes in 85f437c.

RedesMexico commented 3 months ago

Hello

The line 421 is 1 addition ? --- if ($link->level !== 0) {

sonvnn commented 3 months ago

@RedesMexico Just download https://github.com/templaza/astroid-framework/archive/refs/heads/v3.zip and install to your Joomla extension.

Joomlaplates commented 3 months ago

Hello Sonny, yes its working now with new Astroid v3. Thank you!! Greatings Peter