templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
86 stars 17 forks source link

Astroid menu module resets after updating Astroid #854

Closed vtheod closed 1 day ago

vtheod commented 3 weeks ago

Describe the bug After astroid update, the astroid menu module resets it's position from astroid header menu (or astroid header mobilemenu) to status.

To Reproduce Steps to reproduce the behavior: Just puplish an astroid menu module to astroid header menu or to astroid header mobilemenu positions and then update astroid to a later version.

Expected behavior the module's position will be reset

Screenshots Before the update: Before_update

After the update: After_update

System Informations (please complete the following information):

Additional context Add any other context about the problem here.

rinka88 commented 3 weeks ago

I confirm This happens when updating a template. When discussing 3.1.7 RC talked about this

vtheod commented 3 weeks ago

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

rinka88 commented 3 weeks ago

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

by the word template I meant framework

sonvnn commented 3 weeks ago

@rinka88 @vtheod It's my mistake. I will fix it in the next version. Please wait for the update.

sonvnn commented 3 weeks ago

@vtheod @rinka88 I fixed this issue at https://github.com/templaza/astroid-framework/commit/6f99ee765bceb6f7bd0ed332254dfefaf9898506 Please help me download v3-branch and test it.

Best Regards, Sonny

vtheod commented 3 weeks ago

I installed it and it seems that the issue is fixed. Thanks @sonvnn I just noticed that after installation, the icon in the get started button doesn't display:

Screenshot 2024-11-01 at 09-56-50 Extensions Install - Administration

rinka88 commented 3 weeks ago

thanks for the correction