templaza / astroid-framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://astroidframe.work/
GNU General Public License v3.0
86 stars 15 forks source link

SmoothScroll is not working anymore #860

Open Joomlaplates opened 3 weeks ago

Joomlaplates commented 3 weeks ago

Astroid 3.1.7 Template TWO Joomla 5.2 .. The Smoothscroll from menu is not working anymore. https://compassionate-bardeen.85-214-95-104.plesk.page/

Regards Peter

Joomlaplates commented 2 weeks ago

You can fix it with adding following code, see picture scroll The script found on Codepen https://codepen.io/cferdinandi/pen/wQzrdM

WM-Loose commented 2 weeks ago

I can confirm this and Peter's solution works. Until it is solved, all our customers should deactivate Smoothscroll.

WM-Loose commented 2 weeks ago

It works with Chrome and Edge. So we checked Firefox again and found that the smooth gliding function was not activated there. After activating it, it now works in Firefox too.

FF options /surfing / smooth gliding = on

sonvnn commented 2 weeks ago

@Joomlaplates @WM-Loose I am sorry that I cannot reproduce the issue you mentioned on Chrome, Firefox, Safari. I have tried on different computers in my company and cannot find the problem here. Can you please help me create a video recording the problems on your screen. This will help me to know how to find the problem more clearly.

tmumm commented 2 weeks ago

I've found the same thing, you can see on my test site: https://capture.dropbox.com/oZ5sLSd6D25iYAjE That was me scrolling down as normal on the site here: https://www.thirdsun.site/ This is only an issue in Chrome for me.

sonvnn commented 2 weeks ago

@Joomlaplates @WM-Loose @tmumm I fixed this issue at https://github.com/templaza/astroid-framework/commit/0dade23004d255c04b2bdcef7832d172ad143cc9 I also brought the Scroll Speed option back. Please help me download v3-branch and retest again. Hope you like it.

WM-Loose commented 2 weeks ago

Test positiv :-) Now it works as it should.

Joomlaplates commented 2 weeks ago

Yes it working now. Thank you Sonny

WM-Loose commented 2 weeks ago

Hi Sonny, I just realized that there is still a problem. If smoothscroll is activated, scrolling with mousewheel in the offcanvas window no longer works. Only when smoothscroll is deactivated can you scroll up and down in the offcanvas window again with the mouse wheel. Unfortunately, I only just noticed it.

sonvnn commented 2 weeks ago

Thank you! I will check it and response asap

sonvnn commented 1 week ago

@WM-Loose I fixed issue of Smooth Scroll on Off Canvas at https://github.com/templaza/astroid-framework/commit/38b57be051d1e1fd7d16e47278dd207fa3594e17

Please help me download v3-branch and retest it.

WM-Loose commented 1 week ago

It works perfectly now. Thank you very much Sonny. But I had to find the path to the PHP file first :-) For all users who don't want to search. The PHP file is here: myjoomla/libraries/astroid/framework/frontend/offcanvas.php Sonny, you are great and solved it quickly as always.

Joomlaplates commented 1 week ago

Hi Sonny, yes its working now. Thank you so much