Open cretz opened 2 months ago
Other users protoc from the root of this repo. When https://github.com/temporalio/api/commit/108b40ae508505b64f19ccbe2fdbcd304081391b was done, we put google-based proto dependencies at the same path as our own assuming that all users were ok with using these google protos instead of their own (e.g. from https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf).
protoc
We probably need to either:
api-go
or:
google/api
thirdparty/google-api/google/api
google/protobuf
thirdparty/google-protobuf/google/protobuf
-I thirdparty/google-api
-I thirdparty/google-protobuf
thirdparty
Describe the solution you'd like
Other users
protoc
from the root of this repo. When https://github.com/temporalio/api/commit/108b40ae508505b64f19ccbe2fdbcd304081391b was done, we put google-based proto dependencies at the same path as our own assuming that all users were ok with using these google protos instead of their own (e.g. from https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf).We probably need to either:
protoc
is actually run (e.g.api-go
) and only embed them here when testingor:
google/api
tothirdparty/google-api/google/api
google/protobuf
tothirdparty/google-protobuf/google/protobuf
-I thirdparty/google-api
and-I thirdparty/google-protobuf
to ourprotoc
thirdparty
is nested under our root is ok and can easily be ignored by mostprotoc
use