Adding namespace commands to cli

temporalio / cli

Command-line interface for running Temporal Server and interacting with Workflows, Activities, Namespaces, and other parts of Temporal

https://docs.temporal.io/cli

MIT License

251 stars 35 forks source link

Adding namespace commands to cli #476

Closed prathyushpv closed 6 months ago

prathyushpv commented 6 months ago

What was changed

Adding operator namespace commands to cli. These are the commands that are added

operator namespace create
operator namespace delete
operator namespace describe
operator namespace list
operator nemspace update

Breaking changes

Removed --verbose option from namespace update command. This option is used to print update request payload.
Previous cli was printing historyArchivalUri and visibilityArchivalUri fields only if the option --fields is set to long when executing namespace describe command. Here we are always printing those fields since we dont have --fields option.

Why?

Checklist

How was this tested: Unit tests.
Any docs updates needed?

prathyushpv commented 6 months ago

This is looking great! Only reason I am not approving is because we are still discussing internally on the use of positionals vs --namespace/-n here. It's starting to lean towards the latter which would be a compat break, we'll see. Will get answer soon hopefully.

Also, we need to make sure we document all compat breaks (e.g. removing --verbose) in the PR description.

Thank you! I have updated the description with breaking changes. Let me know when the decision is made about namespace name.

cretz commented 6 months ago

@prathyushpv - after internal discussion, let's go with the way you have it now (which is the way the CLI works today. But if you don't mind, I would like this to way on #487 and put the StartList and EndList calls like you see in that PR on the operator namespace list command.

cretz commented 6 months ago

@prathyushpv - you can merge main and add the StartList/EndList stuff now. Can leave positional params as they are (we don't like it, but we don't have a better answer right now).

prathyushpv commented 6 months ago

@prathyushpv - you can merge main and add the StartList/EndList stuff now. Can leave positional params as they are (we don't like it, but we don't have a better answer right now).

@cretz Thank you! I have added StartList andEndList to listNamespace command.

prathyushpv commented 6 months ago

Looks great, thanks! May have to fix failing CI test.

Thank you!

cretz commented 6 months ago

:+1: Merge whenever you're ready