Closed josh-berry closed 5 months ago
hm... this failed only on Windows but I don't understand why yet. The failures make it look like something very basic is broken (passing the wrong flags etc) that I don't think is related to this change. Will look into this before merging of course.
Looks like a test flake on TestSharedServerSuite/TestActivity_Complete
. Probably just need to up that timeout from 5s to 10s. Not related to anything in this PR surely.
This forward-ports #408 to the cli-rewrite branch.