search

temporalio / cli

Command-line interface for running Temporal Server and interacting with Workflows, Activities, Namespaces, and other parts of Temporal
https://docs.temporal.io/cli
MIT License
247 stars 34 forks source link

Fix racy batch test #516

Closed josh-berry closed 5 months ago

josh-berry commented 5 months ago

This test occasionally fails because the batch job completes before the test has a chance to check its status. Allow for this case in the test.

josh-berry commented 5 months ago

hm... I'm realizing this is incomplete; the terminate test also has the same problem. It's less obvious how to fix that one, though, because success is indistinguishable from failure; if the batch job is already completed, it can't be terminated. (I'm seeing both failures on my Windows box pretty reliably.)

I think this one can still be merged as-is, but someone (maybe/probably me) will need to do a follow-up PR for the terminate test.