search

temporalio / cli

Command-line interface for running Temporal Server and interacting with Workflows, Activities, Namespaces, and other parts of Temporal
https://docs.temporal.io/cli
MIT License
243 stars 32 forks source link

[Feature Request] CLI rewrite needs to support "pretty" log format and log level for older SDKs #533

Closed cretz closed 2 months ago

cretz commented 3 months ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

All SDKs basically expect server start-dev to be able to set --log-format to something like "pretty" and --log-level to a needed value (Go, TS, Python, .NET, Core, etc). Today we have no concept of --log-format of "pretty", just text and json, and we have no concept of --log-level for just server, we have --log-level-server which we intentionally separated because we want warn the default there.

Suggestion: Add pretty as an alias for text in --log-format, and change --log-level-server to default to --log-level if not set, and change --log-level default for just this command to warn.

josh-berry commented 3 months ago

Your suggestion seems fine to me. 👍

cretz commented 2 months ago

Done in #535