temporalio / cli

Command-line interface for running Temporal Server and interacting with Workflows, Activities, Namespaces, and other parts of Temporal
https://docs.temporal.io/cli
MIT License
251 stars 36 forks source link

Batch rate limit #551

Closed stephanos closed 5 months ago

stephanos commented 5 months ago

What was changed

Added support for passing --rps flag to batch operations.

ℹ️ FYI I've only added a single test for TerminateWorkflow, even though there are 3 batch APIs. Reason being that the API is the same and the only difference is the "operation". Let me know if I should add it to the others as well.

❓ Note sure why I'm seeing the CLA request on my PR.

Checklist

  1. Closes

  2. How was this tested: Added new tests.

  3. Any docs updates needed?

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

tlalfano commented 5 months ago

Let's make sure this is in the next CLI release.

antlai-temporal commented 4 months ago

@stephanos I think the cli-rewrite branch is dead, main becoming the new target branch for the last two weeks, you may want to merge in main instead... @cretz Can you confirm? I'm going to use your float changes for one of my flags, thanks for doing that!